feat: make facet providers scalable to enable LOD chunks #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
reviewed
Aug 13, 2021
| @@ -67,6 +68,7 @@ protected WorldBuilder createWorld() { | |||
| .addRasterizer(new TreeRasterizer()) | |||
| .addRasterizer(new OreRasterizer()) | |||
| .addRasterizer(new DiscoverablesRasterizer()) | |||
| .addRasterizer(new SunlightRasterizer(-20)) | |||
There was a problem hiding this comment.
This is need to have the LOD chunks properly lit. This is what it looks without this additional rasterizer:
skaldarnar
added
Topic: WorldGen
skaldarnar
approved these changes
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOD chunks still don't actually show up with this enabled, and I haven't figured out why yet, but this and Terasology/DynamicCities#103 is at least part of what's required for them to work.