Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make DefaultMinimapSystem client-only #35

Merged
merged 1 commit into from
Nov 30, 2021
Merged

fix: make DefaultMinimapSystem client-only #35

merged 1 commit into from
Nov 30, 2021

Conversation

jdrueckert
Copy link
Member

Fixes #34

@jdrueckert jdrueckert added Type: Bug Issues reporting and PRs fixing problems Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Size: S Small effort likely only affecting a single area and requiring little to no research Blocker Issue reporting or PR addressing a critical problem that blocks other efforts Status: Needs Testing Requires to be tested in-game Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness labels Nov 20, 2021
@jdrueckert jdrueckert self-assigned this Nov 20, 2021
@jdrueckert
Copy link
Member Author

Testing this with a headless server from source is currently blocked by MovingBlocks/Terasology#4959

@jdrueckert jdrueckert added the Status: Blocked Is currently blocked by missing dependencies, pre-requisites, etc. label Nov 20, 2021
@jdrueckert jdrueckert added Blocker Issue reporting or PR addressing a critical problem that blocks other efforts and removed Blocker Issue reporting or PR addressing a critical problem that blocks other efforts Status: Blocked Is currently blocked by missing dependencies, pre-requisites, etc. Status: Needs Testing Requires to be tested in-game labels Nov 30, 2021
@jdrueckert
Copy link
Member Author

I successfully tested this with a headless server by working around MovingBlocks/Terasology#4959 using the fact that when starting a game for the first time ever in a workspace, the override.cfg will be honored for lack of other options.
With this fix I was able to successfully destroy blocks again 🎉

@jdrueckert jdrueckert merged commit b593b24 into develop Nov 30, 2021
@jdrueckert jdrueckert deleted the fix/34/make-default-minimap-system-client-only branch November 30, 2021 23:30
@jdrueckert
Copy link
Member Author

Release v5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pollend pollend pollend approved these changes

Assignees

@jdrueckert jdrueckert

Labels
Blocker Issue reporting or PR addressing a critical problem that blocks other efforts Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot destroy blocks on Headless Server due to non-fatal NPE
2 participants
@jdrueckert @pollend