Topics #4
Merged
Topics #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <h4 class="media-heading"> | ||
| <%= link_to [@topic, bookmark.url] %> | ||
| <div class"col-md-8"> | ||
| <%= link_to "Delete Bookmark", [@topic, bookmark.url], method: :delete, class: 'btn btn-danger' %> |
There was a problem hiding this comment.
don't use bookmark.url here.
bookmark.url is the path to the external url. We need to use just the bookmark object to create an internal URL for us to delete.
There was a problem hiding this comment.
on line 20 or 22 or both? sorry i was viewing it differently - trying to figure out the best way to display these to see them properly
|
added some comments and a question |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@levicole
and up top it says can't merge, but that is ok probably