Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect Conflict with MoreTags #61

Closed
Kneelawk opened this issue Aug 22, 2022 · 3 comments
Closed

Redirect Conflict with MoreTags #61

Kneelawk opened this issue Aug 22, 2022 · 3 comments

Comments

@Kneelawk
Copy link

The Issue

Both MoreTags and Terraformers-Dirt-API redirect the BlockState.isOf call in CropBlock.getAvailableMoisture, leading to a redirect conflict.

Tested Mod Versions

  • MoreTags v3.0.3 (latest as of this issue)
  • Terraformers-Dirt-API v3.1.0 and v4.1.1 (latest as of this issue) (likely affects all versions in between)

Crash Logs

Crash logs using Terraformers-Dirt-API v3.1.0: https://pastebin.com/xGVeGdjj
Crash logs using Terraformers-Dirt-API v4.1.1: https://pastebin.com/0P6yVzSQ

Potential Solution

Given that both of these redirects appear to be for the purpose of checking if a potential farmland block is part of block tag. Either one of these mods could depend on the other or both could use a less-invasive mixin type like one of the mixins from MixinExtras.
@Kneelawk
Copy link
Author

Issue on MoreTags repository: gudenau/minecraft-MoreTags#22

@Kneelawk Kneelawk mentioned this issue Aug 22, 2022
Open
@gniftygnome gniftygnome mentioned this issue Jan 23, 2023
Closed
@gniftygnome
Copy link
Contributor

I can modify our mixin to prevent the crash, but unless there are changes to More Tags, custom Terraform API farmland will be incompatible with More Tags, so the recommendation (for Terrestria users at least) will remain to not use More Tags unless that mod improves its compatibility.

gniftygnome added a commit that referenced this issue Mar 25, 2023
@gniftygnome
Use Mixin Extras to avoid conflicting crop block mixins (dirt API).
00d1161 
Resolves #61.

- Add dependency on Mixin Extras (allow JiJiJ or JiJ it yourself).
- Use Mixin Extras to avoid conflicts on crop block mixin.
* Declare "breaks" with MoreTags mod until they fix their mixin.
  (Quilt does not support Fabric's "conflicts" relationship.)
@gniftygnome
Copy link
Contributor

Fixed (in our mods beginning with 1.19.4) by JiJing MixinExtras and using WrapOperation ... we'll also conflict with MoreTags until they resolve both aspects of gudenau/minecraft-MoreTags#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kneelawk @gniftygnome