Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wilder Wild integration #106

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

Treetrain1
Copy link
Contributor

Improves compatibility with Wilder Wild by adding this mod's biomes to some of Wilder Wild's tags.

@gniftygnome
Copy link
Collaborator

Hmm, I wish they would use common tags for this kind of thing instead of pushing their maintenance overhead onto the maintainers of all the biome mods...

@Treetrain1
Copy link
Contributor Author

Hmm, I wish they would use common tags for this kind of thing instead of pushing their maintenance overhead onto the maintainers of all the biome mods...

the reason is it would put some features in incorrect places, just speaking vanilla wise
like some features we want in like ordinary forests but not spruce forests for example
i dont think theres a tag of forests excluding stuff like spruce

@gniftygnome
Copy link
Collaborator

i dont think theres a tag of forests excluding stuff like spruce

That is effectively BiomeTags.IS_FOREST && !BiomeTags.IS_TAIGA though... I realize depending on how the features are getting added that might take a little extra effort but IMO it would be well worth it. Several of the tags added by this PR straight-up duplicate our presence in common tags.

has_rare_seeding_dandelion -- ConventionalBiomeTags.PLAINS
has_milkweed -- probably fine with ConventionalBiomeTags.TREE_DECIDUOUS
has_cattail_common and firefly_spawnable_during_day -- ConventionalBiomeTags.SWAMP

The entire reason for creating common tags is to help avoid the situation where the author of one mod gets stuck effectively maintaining the content of another. Even if it's not perfect, that is much better than putting logic for mod X into mods A, B, C, D, etc. And that is without even discussing what would happen if more mods take the route Wilder Wild is and (of course) using their own tags instead of Wilder Wild's tags. X, Y, and Z into A, B, C, D, etc. Madness.

All of that being said, I will accept this PR, but the moment it gets in the way of updates I am making or I start to think it is no longer up to date w.r.t. Wilder Wild, the tags will be removed. I do not have the time to track changes to other biome mods when updating ours.

@gniftygnome gniftygnome marked this pull request as ready for review November 8, 2023 19:35
@gniftygnome gniftygnome merged commit 14fd17f into TerraformersMC:1.20.2 Nov 8, 2023
1 check passed
gniftygnome pushed a commit that referenced this pull request Nov 8, 2023
- Add compatibility tags for Wilder Wild, thanks to Treetrain1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants