Deletion thumbnail sorl #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 99.13% 99.63% +0.50%
==========================================
Files 18 18
Lines 1385 1382 -3
==========================================
+ Hits 1373 1377 +4
+ Misses 12 5 -7
Continue to review full report at Codecov.
|
LePetitTim
force-pushed
the
deleteion_thumbnail_sorl
branch
from
1ed73af
to
f04450a
Compare
LePetitTim
force-pushed
the
deleteion_thumbnail_sorl
branch
from
f04450a
to
d814d0d
Compare
submarcos
reviewed
May 17, 2022
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -40,11 +41,17 @@ def get_thumbnail(self, file_, geometry_string, **options): | |||
| if value != getattr(default_settings, attr): | |||
| options.setdefault(key, value) | |||
|
|
|||
| try: | |||
| source_image = default.engine.get_image(source) | |||
| options['hash'] = hashlib.md5(source_image.tobytes()).hexdigest() | |||
There was a problem hiding this comment.
Use of insecure MD2, MD4, MD5, or SHA1 hash function.
submarcos
reviewed
May 17, 2022
terra_geocrud/properties/files.py
Outdated
| # patch file_infos with new path | ||
| detail_infos = file_info.split(';name=') | ||
| new_info = f"{detail_infos[0]};name={storage_file_path}" | ||
| new_info = f"{detail_infos[0]};name={stored_name}" |
There was a problem hiding this comment.
because it's not only name but path in storage I prefer to keep storage_file_path
|
Code Climate has analyzed commit 88271ce and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.