-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deletion thumbnail sorl #120
Conversation
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 99.13% 99.63% +0.50%
==========================================
Files 18 18
Lines 1385 1382 -3
==========================================
+ Hits 1373 1377 +4
+ Misses 12 5 -7
Continue to review full report at Codecov.
|
1ed73af
to
f04450a
Compare
f04450a
to
d814d0d
Compare
@@ -40,11 +41,17 @@ def get_thumbnail(self, file_, geometry_string, **options): | |||
if value != getattr(default_settings, attr): | |||
options.setdefault(key, value) | |||
|
|||
try: | |||
source_image = default.engine.get_image(source) | |||
options['hash'] = hashlib.md5(source_image.tobytes()).hexdigest() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of insecure MD2, MD4, MD5, or SHA1 hash function.
terra_geocrud/properties/files.py
Outdated
# patch file_infos with new path | ||
detail_infos = file_info.split(';name=') | ||
new_info = f"{detail_infos[0]};name={storage_file_path}" | ||
new_info = f"{detail_infos[0]};name={stored_name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it's not only name but path in storage I prefer to keep storage_file_path
Code Climate has analyzed commit 88271ce and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.