Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMS] Prevent users from entering values outside of the threshold values for Place lat/long fields #442

Closed
rudokemper opened this issue Jun 5, 2020 · 1 comment
Closed

[CMS] Prevent users from entering values outside of the threshold values for Place lat/long fields #442

rudokemper opened this issue Jun 5, 2020 · 1 comment
Assignees
@Lukmin1999
Labels
beginner friendly Good for newcomers rails

Comments

@rudokemper
Copy link
Member

Currently, it is possible to enter a value for the lat field that exceeds the boundaries of -90 to 90, and -180 to 190 for the long field.

This consequently breaks the map when you return to the home view.

An error message should pop up in Administrate when a user tries to enter values outside of the treshholds for the Latitude and Longitude fields.
@rudokemper rudokemper added beginner friendly Good for newcomers rails labels Jun 5, 2020
@Lukmin1999
Copy link
Contributor

I could tackle this one.

Lukmin1999 added a commit to Lukmin1999/terrastories that referenced this issue Jun 23, 2020
@Lukmin1999
Added bounds to the lat and long variables
edd1d14 
This addresses issue Terrastories#442, and prevents users from editing places such that their lat and long variables exceed the normal bounds to latitudinal and longitudinal coordinates
FeminismIsAwesome added a commit that referenced this issue Jun 28, 2020
@Lukmin1999 @FeminismIsAwesome
@ohamuy @kathenry @maebeale
Addressed an issue with Place.rb (#449)
262d12f 
* Update seeds.rb

Stories were not loading properly: They needed at least one associated speaker to pass validation.

Co-authored-by: Ian <ian.norris.1991@gmail.com>
Co-authored-by: Oliver <o.hamuy@wustl.edu>
Co-authored-by: Katherine <kfhenry@wustl.edu>
Co-authored-by: maebeale <maebeale@gmail.com>

* Added bounds to the lat and long variables

This addresses issue #442, and prevents users from editing places such that their lat and long variables exceed the normal bounds to latitudinal and longitudinal coordinates

Co-authored-by: Ian <ian.norris.1991@gmail.com>
Co-authored-by: Oliver <o.hamuy@wustl.edu>
Co-authored-by: Katherine <kfhenry@wustl.edu>
Co-authored-by: maebeale <maebeale@gmail.com>
Lukmin1999 added a commit to Lukmin1999/terrastories that referenced this issue Jul 7, 2020
@Lukmin1999 @FeminismIsAwesome
@ohamuy @kathenry @maebeale
Addressed an issue with Place.rb (Terrastories#449)
d7b755d 
* Update seeds.rb

Stories were not loading properly: They needed at least one associated speaker to pass validation.

Co-authored-by: Ian <ian.norris.1991@gmail.com>
Co-authored-by: Oliver <o.hamuy@wustl.edu>
Co-authored-by: Katherine <kfhenry@wustl.edu>
Co-authored-by: maebeale <maebeale@gmail.com>

* Added bounds to the lat and long variables

This addresses issue Terrastories#442, and prevents users from editing places such that their lat and long variables exceed the normal bounds to latitudinal and longitudinal coordinates

Co-authored-by: Ian <ian.norris.1991@gmail.com>
Co-authored-by: Oliver <o.hamuy@wustl.edu>
Co-authored-by: Katherine <kfhenry@wustl.edu>
Co-authored-by: maebeale <maebeale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lukmin1999 Lukmin1999

Labels
beginner friendly Good for newcomers rails
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lauramosher @rudokemper @Lukmin1999