Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rspec tests #461

Closed
lauramosher opened this issue Jul 5, 2020 · 5 comments
Closed

Fix rspec tests #461

lauramosher opened this issue Jul 5, 2020 · 5 comments
Assignees
Labels
beginner friendly Good for newcomers rails

Comments

@lauramosher
Copy link
Contributor

Right now, if you run docker-compose run web-test rspec, there are a number of failing specs.

Finished in 14.18 seconds (files took 3.24 seconds to load)
84 examples, 21 failures

This issue is to work through those failing specs and make them pass.

@lauramosher lauramosher added beginner friendly Good for newcomers rails labels Jul 5, 2020
@slaloggia
Copy link
Contributor

I'll take this! A lot of them appear to be due to a fix I implemented for a different issue anyway, so I should have updated the specs then.

@slaloggia
Copy link
Contributor

The .import_csv tests were failing bc the Place model is validating lat & and long. Should those be allowed to be blank or do we only want Places to be created with a latitude and longitude?

@lauramosher
Copy link
Contributor Author

Should those be allowed to be blank or do we only want Places to be created with a latitude and longitude?

I would say allowed to be blank but I am not sure what the original ticket was asking. @Terrastories/terrastories-stewards pinging to see if you have any input on the preference for lat/long requirements.

@slaloggia
Copy link
Contributor

Is there anything else that wasn't addressed by that PR, or can this be closed?

@lauramosher
Copy link
Contributor Author

@slaloggia This can be closed. I'm so used to them being closed automatically. 🙈

In the future, you can tag a PR with one of the github keywords so it will automatically close this out. In the one linked above, instead of using "Address issue #461" you can use "fixed #461" or "closes #461." Here are all of the documented keywords that will close the associated issue: https://docs.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords

Thank you so much for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner friendly Good for newcomers rails
Projects
None yet
Development

No branches or pull requests

2 participants