-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rspec tests #461
Comments
I'll take this! A lot of them appear to be due to a fix I implemented for a different issue anyway, so I should have updated the specs then. |
The .import_csv tests were failing bc the Place model is validating lat & and long. Should those be allowed to be blank or do we only want Places to be created with a latitude and longitude? |
I would say allowed to be blank but I am not sure what the original ticket was asking. @Terrastories/terrastories-stewards pinging to see if you have any input on the preference for lat/long requirements. |
Is there anything else that wasn't addressed by that PR, or can this be closed? |
@slaloggia This can be closed. I'm so used to them being closed automatically. 🙈 In the future, you can tag a PR with one of the github keywords so it will automatically close this out. In the one linked above, instead of using "Address issue #461" you can use "fixed #461" or "closes #461." Here are all of the documented keywords that will close the associated issue: https://docs.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords Thank you so much for your work on this! |
Right now, if you run
docker-compose run web-test rspec
, there are a number of failing specs.This issue is to work through those failing specs and make them pass.
The text was updated successfully, but these errors were encountered: