Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hide magic DataTable/CSV columns from Feature Info popup #914

Closed
meh9 opened this issue Sep 15, 2015 · 3 comments
Closed

Do not hide magic DataTable/CSV columns from Feature Info popup #914

meh9 opened this issue Sep 15, 2015 · 3 comments

Comments

@meh9
Copy link
Contributor

meh9 commented Sep 15, 2015

There are some columns in DataTable/CSV's that have special meaning - elevation, time, date, etc, which are used to place a point in 3D space or for generating timeseries control. When matched, the data is then not shown in the Feature Info popup when you click on a feature. However, in most cases we actually want to see the values even if they are used for other purposes. For example, if we hide the elevation data, the user can only get a visualisation of that information back if they tilt their view, but if the user never does that the information has simply been lost to them.

@stevage
Copy link
Contributor

stevage commented Sep 15, 2015

Specifically, VarType.ALT and VarType.TIME should not be suppressed. It's probably still right to hide LON and LAT.

@stevage
Copy link
Contributor

stevage commented Sep 17, 2015

Oh, for some reason I misread this as talking about the variables shown in the "Now Viewing" tab. Probably ok to show everything in the popup.

@stevage
Copy link
Contributor

stevage commented Sep 17, 2015

Wait, I misunderstood this issue again. :) That commit doesn't address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants