Very rough approach for implementing language settings

[rowanwins]

Related to #3707 where it's suggested to changing the naming of some buttons are parts of the interface.

This approach would see languageOverrides to be passed in from TerriaMap to via the options to Terria.js

The main downside I've seen so far is that some text components occasionally include React components like Icons, for example empty workbench has a message which includes a lightbulb icon. The current approach doesn't render those react components. Someone much better with React would probably have a few ideas how to handle this.

What I've done in TerriaMap/index.js is

import languageOverrides from './lib/Language/overrides';

terriaOptions.languageOverrides = languageOverrides;

These overrides then get merged into the defaults.

Anyway this is my very naive approach :)

[soyarsauce]

So there's a few ways around the icon problem, e.g. feeding in an actual react component as part of the "i18n"/language config, or the simplest way for now is to keep the existing components as "defaults" (with icon), then overrides means no icon-ability atm.

[rowanwins]

I'll do a quick audit tomorrow of how many places we use components within regular HTML, if it's only the lightbulb icon in that empty workbench effected then I'm happy to have no icon-ability :)

[kring]

@rowanwins @soyarsauce why not use https://github.com/TerriaJS/terriajs/blob/master/lib/ReactViews/Custom/parseCustomMarkdownToReact.js to render the localized "strings". Then you can support icons by defining a custom component (https://github.com/TerriaJS/terriajs/blob/master/lib/ReactViews/Custom/registerCustomComponentTypes.js). It sanitizes the input too.

[rowanwins]

Good idea @kring - I'll give it a whirlybird!

[rowanwins]

Okay @kring & @soyarsauce - the latest commit adds support for Icon's as customComponents.

The other component that comes to mind that might be nice to support via custom text is the Button component, eg I'm thinking about the possibility of buttons in that empty workbench area...

Before I add support for the Buttons do you want to make sure you're happy with that handling for the Icon component?
EDIT: We don't use a fancy button component, just regular old buttons with a few classes work fine!

And are we happy to proceed and get this into master?

On a sidenote there is also some similar stuff that we do via the config.json in TerriaMap (eg we have a feedbackPreamble option - who knew!! At some stage it would be good to rationalise.

[rowanwins]

Theoretically the Icon.jsx also takes a style object as a prop however this would be a smidge fiddily to support as we'd basically be taking a string and converting it to a object. I reckon we just support styling via the className prop.

[AnaBelgun]

reminder to @soyarsauce to review this one

[soyarsauce]

This is awesome work @rowanwins & looks good, hope you don't mind I just extended so we can also use any component/jsx, if the latest commit looks good to you, let's merge it
a7305b0

[rowanwins]

Looks good to me @soyarsauce - it doesn't seem like I can merge it because I can't review it because I opened the PR, but I've looked over it and tested locally and it all makes sense.
I'll open a corresponding PR over in the TerriaMap repo.

[soyarsauce]

Sorry @rowanwins I thought I approved w/ my single comment review