Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for alpha of outline when deselecting a feature #4635

Merged
merged 2 commits into from Aug 14, 2020
Merged

Conversation

rowanwins
Copy link
Contributor

What this PR does

When selecting a feature on the map it is highlighted changing the symbology. I noticed that when deselecting a feature the outline was sometimes becoming invisible when it had previously been visible. This PR ensures that the alpha of the outline is re-adopted.

Checklist

  • No unit tests
  • I've updated CHANGES.md with what I changed.

Copy link
Contributor

@soyarsauce soyarsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the preview links, made it really easy to verify given lack of unit test

@rowanwins rowanwins merged commit d120d1f into master Aug 14, 2020
@rowanwins rowanwins deleted the fix-highlighting branch August 14, 2020 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants