Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore cesiumTerrainUrl parameter #5124

Merged
merged 6 commits into from Feb 8, 2021
Merged

Restore cesiumTerrainUrl parameter #5124

merged 6 commits into from Feb 8, 2021

Conversation

zoran995
Copy link
Contributor

@zoran995 zoran995 commented Jan 8, 2021 •
edited

What this PR does

Fixes #

cesiumTerrainUrl is missing on the next branch. This PR restores it support, and also i18n-ify strings in the settings panel.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated CHANGES.md with what I changed.

@nf-s nf-s self-assigned this Jan 19, 2021
@zoran995 zoran995 mentioned this pull request Jan 25, 2021
Open
7 tasks
@zoran995
Copy link
Contributor Author

Need to document this before it's merged.

@zoran995 zoran995 changed the title Restore customTerrainUrl parameter Restore cesiumTerrainUrl parameter Feb 2, 2021
@nf-s
Copy link
Contributor

nf-s commented Feb 8, 2021

Love it! thanks @zoran995

@nf-s nf-s merged commit e1e6985 into TerriaJS:next Feb 8, 2021
@zoran995 zoran995 deleted the custom-terrain branch March 28, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nf-s nf-s nf-s approved these changes

Assignees

@nf-s nf-s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zoran995 @nf-s