-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tsify explorer window and data catalog #6466
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to get around to applying prettier2 to this and merging later this week.
The last tag just before prettier v2 was run
The tag immediately after prettier v2 was run in main
Got the prettier v2 merge & merge from |
@@ -23,7 +23,7 @@ const ActionBarPortal: React.FC<PropsType> = ({ show }) => { | |||
const StyledPortal = styled(Portal)<{ show: boolean }>` | |||
display: flex; | |||
position: absolute; | |||
height: 56px; | |||
height: ${(p) => (p.show ? "56px" : "0")}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was necessary as element of screen was causing the whole page to move as scrollable on scrollIntoView
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @na9da
Hi @steve9164, are there any plans to merge this? I might get some time next week to get this in sync with the latest main. |
Yes. With some small fixes to the styling we can get this merged. Here are a couple of cases:
|
It might be worth waiting til next week for the React 18 upgrade to be merged into main (see #6902 - just fixing some tests on it now). |
Hi @steve9164, @nf-s is still of interest to the team? |
What this PR does
Fixes #5204
Move of explorer window and data catalog to ts and styled-components.
Test me
Checklist
doc/
.