Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade typescript to 5.2 #6997

Merged
merged 9 commits into from
Dec 13, 2023
Merged

Upgrade typescript to 5.2 #6997

merged 9 commits into from
Dec 13, 2023

Conversation

steve9164
Copy link
Member

@steve9164 steve9164 commented Dec 3, 2023 •
edited
Loading

What this PR does

Offshoot of #6902.

  • Upgrades TypeScript to 5.3 5.2
  • Improve tsconfig files
  • Switch to new JSX transform (added in React 17 and backported to React 16.14)

Test me

http://ci.terria.io/ts5/

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@steve9164 steve9164 marked this pull request as draft December 3, 2023 15:38
@steve9164
Copy link
Member Author

steve9164 commented Dec 3, 2023 •
edited
Loading

☹️ TS 5.2 -> 5.3 upgrade breaks our cursed super access: microsoft/TypeScript#35314

@steve9164 steve9164 changed the title Upgrade typescript to 5.3 Upgrade typescript to 5.2 Dec 4, 2023
@steve9164 steve9164 marked this pull request as ready for review December 6, 2023 02:23
ljowen
ljowen reviewed Dec 6, 2023
View reviewed changes
tsconfig-node.json Outdated Show resolved Hide resolved
@steve9164 @ljowen
Update tsconfig-node.json
2cf8f4a 
Co-authored-by: Lawrence Owen <lawrence.owen@csiro.au>
ljowen
ljowen reviewed Dec 6, 2023
View reviewed changes
tsconfig.json Show resolved Hide resolved
@nf-s nf-s mentioned this pull request Dec 7, 2023
Closed
@nf-s
Copy link
Contributor

nf-s commented Dec 13, 2023

Ready to merge in now

@steve9164 steve9164 merged commit b48a1d7 into main Dec 13, 2023
5 checks passed
@steve9164 steve9164 deleted the ts5 branch December 13, 2023 04:28
@steve9164 steve9164 mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljowen ljowen ljowen approved these changes

Assignees

@ljowen ljowen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@steve9164 @nf-s @ljowen