Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad JSON strings in feature properties #7113

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Conversation

nf-s
Copy link
Contributor

@nf-s nf-s commented Apr 18, 2024

Fix bad JSON strings in feature properties

  • Fix getFeatureProperties (in FeatureInfoSection) failing due to bad JSON parsing of nested strings.
  • The TableFeatureInfoStratum default featureInfoTemplate will now not show _id_ (internal Terria feature ID) in feature info

Test me

  • Before
  • After
  • Click on feature
  • Before you will see "Some Bad Json" and "Id" but they will both be empty
  • After you will see "Some Bad Json" = "{Hello}"

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@AnaBelgun AnaBelgun assigned nf-s and unassigned steve9164 May 31, 2024
@nf-s nf-s merged commit 6abc5ac into main Jun 6, 2024
9 checks passed
@nf-s nf-s deleted the fix-feature-prop-json branch June 6, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants