Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imgur provider #110

Merged
merged 18 commits into from
Jul 17, 2015
Merged

Add imgur provider #110

merged 18 commits into from
Jul 17, 2015

Conversation

kappa7194
Copy link
Contributor

Hello, I've added a provider for imgur. The implementation is complete and it works.

I know I haven't (yet) added the XML documentation to the code, I've submitted this pull request to get feedbacks on the implementation.

P.s. How would you like me to handle the two errors marked by TODOs in ImgurAuthenticationHandler (communication failure and response deserialization failure)? Should I throw an exception?

@jerriep
Copy link
Contributor

jerriep commented Jul 13, 2015

Thanks for contribution. I have scheduled to look at this on Friday

@kappa7194
Copy link
Contributor Author

If you could let me know how I should handle any exception thrown by the HttpClient and/or failure codes returned when dealing with the remote endpoint (I couldn't see a common behaviour in the existing providers) I'll have everything ready and shiny by Friday.

@jerriep
Copy link
Contributor

jerriep commented Jul 13, 2015

Yeah if there is no common implementation, then I would say to just go ahead and implement it as you feel comfortable with.

@kappa7194
Copy link
Contributor Author

I've committed some refactoring and the XML documentation.

Let me know if you find any issue.

@jerriep
Copy link
Contributor

jerriep commented Jul 15, 2015

👍

@jerriep jerriep merged commit 70fae47 into TerribleDev:master Jul 17, 2015
@jerriep
Copy link
Contributor

jerriep commented Jul 17, 2015

Thanks again @kappa7194

I am waiting for feedback on another PR before I do a new release

@kappa7194 kappa7194 deleted the imgur branch July 17, 2015 06:14
@jerriep
Copy link
Contributor

jerriep commented Sep 8, 2015

@kappa7194 We are looking for help moving to ASP.NET 5. Please read http://www.jerriepelser.com/blog/calling-contributors-for-oauth-providers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants