-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add imgur provider #110
Add imgur provider #110
Conversation
Thanks for contribution. I have scheduled to look at this on Friday |
If you could let me know how I should handle any exception thrown by the HttpClient and/or failure codes returned when dealing with the remote endpoint (I couldn't see a common behaviour in the existing providers) I'll have everything ready and shiny by Friday. |
Yeah if there is no common implementation, then I would say to just go ahead and implement it as you feel comfortable with. |
I've committed some refactoring and the XML documentation. Let me know if you find any issue. |
👍 |
Thanks again @kappa7194 I am waiting for feedback on another PR before I do a new release |
@kappa7194 We are looking for help moving to ASP.NET 5. Please read http://www.jerriepelser.com/blog/calling-contributors-for-oauth-providers |
Hello, I've added a provider for imgur. The implementation is complete and it works.
I know I haven't (yet) added the XML documentation to the code, I've submitted this pull request to get feedbacks on the implementation.
P.s. How would you like me to handle the two errors marked by TODOs in ImgurAuthenticationHandler (communication failure and response deserialization failure)? Should I throw an exception?