Add a Request Prefix to Options so that we don't rely always on Request.Scheme or Request.Host. #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2018 16:33
…rely always on Request.Scheme or Request.Host.
|
Hello, I'm traveling atm and won't be back until Friday. If I do not respond to your PR after Friday feel free to ping this thread. |
|
Bump as requested :) |
|
Looks good, thanks for the bump...I'll try to deploy this later tonight when I get home. Sorry for dealing with my travel and what not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're developing an application that relies on how this variable is being used internally and would like it to be an Option for those who want to set it beforehand.
The issue at the moment is that Request.Scheme and Request.Host are not exactly following what is standard and we end up with an incorrect "redirect_uri" on the query string that is sent to the Twitch API.
This change will only add a small option to those that need to change this parameter.