Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLUM-554: Do not allow None values in Config object #60

Merged
merged 2 commits into from
Aug 22, 2019
Merged

PLUM-554: Do not allow None values in Config object #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
887445a
PLUM-554: Do not allow None values in Config object
SukiCZ Aug 13, 2019
8dbaf65
PLUM-554: Update error message for None values in ConfigDefaults
SukiCZ Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions asab/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,10 @@ def __init__(self, config_section_name, config=None):

# Merge config defaults of each base class in the 'inheritance' way
for key, value in base_class.ConfigDefaults.items():

if value is None:
raise ValueError("None value not allowed in ConfigDefaults. Found in %s:%s " % (config_section_name, key))

if key not in self.Config:
self.Config[key] = value

Expand Down