Disable CMake install rule if robin_map is used as subproject #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Jun 16, 2023
Changes: https://github.com/Tessil/robin-map/releases/tag/v1.2.0 Changes: Tessil/robin-map@784245b...d37a410 * Tessil/robin-map@d37a410: Update CMake tsl-robin-map to v1.2.1 * Tessil/robin-map@68ff732: Keep rehashing if dist_from_ideal_bucket is > DIST_FROM_IDEAL_BUCKET_LIMIT during insertion (fix issue Tessil/robin-map#52) * Tessil/robin-map@6775231: Disable CMake install rule if robin_map is used as subproject (Tessil/robin-map#60) * Tessil/robin-map@57c9b65: Replace depecrated std::aligned_storage since C++23 by alignas (Tessil/robin-map#61) * Tessil/robin-map@d3131e4: Raise DIST_FROM_IDEAL_BUCKET_LIMIT to 8192 * Tessil/robin-map@f8e0f67: Add assertion to make sure that static_empty_bucket_ptr is empty * Tessil/robin-map@ac1e3d8: Add some extra assertions for clarity and ease of debug * Tessil/robin-map@f1e7457: Clear and shrink the moved hash table in the move operator to be coherent with the move constructor * Tessil/robin-map@4abcc97: When using C++17, std::launder the reinterpreted pointer from std::aligned_storage to adapt to the change of object model introduced in P0137R1. Fix potential undefined behaviour. * Tessil/robin-map@c77f80b: Update link to Conan package * Tessil/robin-map@c7595ba: Apply clang-format --style=Google * Tessil/robin-map@37e94dc: When exceptions are disabled, only print the error message when defined(TSL_DEBUG) instead of !defined(NDEBUG) * Tessil/robin-map@59a3b7d: Fix test_extreme_bucket_count_value_construction test on some platforms * Tessil/robin-map@0c3c858: Check that bucket_count doesn't exceed max_bucket_count() after the constructor initialization The robin-map fast map implementation is used in our p/invoke dispatch mechanism (38aa561). The new version is a recommended upgrade. It doesn't appear to contain fixes that affect us, but it's better to be safe than sorry, right? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable CMake install rule if robin_map is used as subproject to avoid robin-map to be installed if the parent project install rule is used.
Solve issue #59