Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable install rule if robin-map is a subproject #59

Closed
SachinVin opened this issue Nov 26, 2022 · 3 comments
Closed

Disable install rule if robin-map is a subproject #59

SachinVin opened this issue Nov 26, 2022 · 3 comments

Comments

@SachinVin
Copy link

Hello,
Recently a user reported that robin-map is installed when make install is used with our project.
A check to disable install whe robin-map is a subproject, would be great.

Examples of how a couple of other projects do it -
SDL: https://github.com/libsdl-org/SDL/blob/main/CMakeLists.txt#L3349

Catch2: https://github.com/catchorg/Catch2/blob/devel/CMakeLists.txt#L111

Thanks!

@Tessil
Copy link
Owner

Tessil commented Dec 2, 2022

Thank you for the report. I created a PR to fix the issue, could you take a look to check it works for you?

@SachinVin
Copy link
Author

Thanks, that looks good!

@Tessil
Copy link
Owner

Tessil commented Dec 18, 2022

Thanks, I merged the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants