Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test::DistManifest for 1.5 #327

Closed
schwern opened this issue Aug 2, 2012 · 1 comment
Closed

Fix Test::DistManifest for 1.5 #327

schwern opened this issue Aug 2, 2012 · 1 comment

Comments

@schwern
Copy link
Contributor

schwern commented Aug 2, 2012

1.012 fails.

Nothing important in its CPAN dependents. Low priority.

PERL_DL_NONLAZY=1 /Users/schwern/perl5/perlbrew/perls/perl-5.14.1/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/01compile.t ............... ok   
t/02manifest.t .............. ok   
t/03core.t .................. 1/? 
#   Failed test 'Fails when MANIFEST cannot be parsed'
#   at t/03core.t line 32.
# STDOUT is:
#1..4
# not ok 1 - Parse MANIFEST or equivalent
# not ok 2 - All files are listed in MANIFEST or skipped
# ok 3 - All files listed in MANIFEST exist on disk
# ok 4 - No files are in both MANIFEST and MANIFEST.SKIP
# 
# not:
# not ok 1 - Parse MANIFEST or equivalent
# 
# not ok 2 - All files are listed in MANIFEST or skipped
# 
# ok 3 - All files listed in MANIFEST exist on disk
# 
# ok 4 - No files are in both MANIFEST and MANIFEST.SKIP
# 
# as expected

#   Failed test 'Fails when MANIFEST contains extra files'
#   at t/03core.t line 45.
# STDOUT is:
#1..4
# ok 1 - Parse MANIFEST or equivalent
# not ok 2 - All files are listed in MANIFEST or skipped
# not ok 3 - All files listed in MANIFEST exist on disk
# ok 4 - No files are in both MANIFEST and MANIFEST.SKIP
# 
# not:
# ok 1 - Parse MANIFEST or equivalent
# 
# not ok 2 - All files are listed in MANIFEST or skipped
# 
# not ok 3 - All files listed in MANIFEST exist on disk
# 
# ok 4 - No files are in both MANIFEST and MANIFEST.SKIP
# 
# as expected

#   Failed test 'Fails when files are in both MANIFEST and MANIFEST.SKIP'
#   at t/03core.t line 59.
# STDOUT is:
#1..4
# ok 1 - Parse MANIFEST or equivalent
# ok 2 - All files are listed in MANIFEST or skipped
# ok 3 - All files listed in MANIFEST exist on disk
# not ok 4 - No files are in both MANIFEST and MANIFEST.SKIP
# 
# not:
# ok 1 - Parse MANIFEST or equivalent
# 
# ok 2 - All files are listed in MANIFEST or skipped
# 
# ok 3 - All files listed in MANIFEST exist on disk
# 
# not ok 4 - No files are in both MANIFEST and MANIFEST.SKIP
# 
# as expected
#3 tests of 8 failed.
t/03core.t .................. Failed 3/8 subtests 
t/03warn-only.t ............. 1/? 
#   Failed test 'Fails when MANIFEST cannot be parsed'
#   at t/03warn-only.t line 30.
# STDOUT is:
#1..4
# not ok 1 - Parse MANIFEST or equivalent
# ok 2 - All files are listed in MANIFEST or skipped
# ok 3 - All files listed in MANIFEST exist on disk
# ok 4 - No files are in both MANIFEST and MANIFEST.SKIP
# 
# not:
# not ok 1 - Parse MANIFEST or equivalent
# 
# ok 2 - All files are listed in MANIFEST or skipped
# 
# ok 3 - All files listed in MANIFEST exist on disk
# 
# ok 4 - No files are in both MANIFEST and MANIFEST.SKIP
# 
# as expected

#   Failed test 'Succeeds even when MANIFEST contains extra files'
#   at t/03warn-only.t line 43.
# STDOUT is:
#1..4
# ok 1 - Parse MANIFEST or equivalent
# ok 2 - All files are listed in MANIFEST or skipped
# ok 3 - All files listed in MANIFEST exist on disk
# ok 4 - No files are in both MANIFEST and MANIFEST.SKIP
# 
# not:
# ok 1 - Parse MANIFEST or equivalent
# 
# ok 2 - All files are listed in MANIFEST or skipped
# 
# ok 3 - All files listed in MANIFEST exist on disk
# 
# ok 4 - No files are in both MANIFEST and MANIFEST.SKIP
# 
# as expected

#   Failed test 'Fails when files are in both MANIFEST and MANIFEST.SKIP'
#   at t/03warn-only.t line 57.
# STDOUT is:
#1..4
# ok 1 - Parse MANIFEST or equivalent
# ok 2 - All files are listed in MANIFEST or skipped
# ok 3 - All files listed in MANIFEST exist on disk
# not ok 4 - No files are in both MANIFEST and MANIFEST.SKIP
# 
# not:
# ok 1 - Parse MANIFEST or equivalent
# 
# ok 2 - All files are listed in MANIFEST or skipped
# 
# ok 3 - All files listed in MANIFEST exist on disk
# 
# not ok 4 - No files are in both MANIFEST and MANIFEST.SKIP
# 
# as expected
#3 tests of 4 failed.
t/03warn-only.t ............. Failed 3/4 subtests 
t/release-01-no-manifest.t .. skipped: these tests are for release candidate testing
t/release-dist-manifest.t ... skipped: these tests are for release candidate testing
t/release-kwalitee.t ........ skipped: these tests are for release candidate testing
t/release-pod-coverage.t .... skipped: these tests are for release candidate testing
t/release-pod-syntax.t ...... skipped: these tests are for release candidate testing
t/release-portability.t ..... skipped: these tests are for release candidate testing

Test Summary Report
-------------------
t/03core.t                (Wstat: 0 Tests: 8 Failed: 3)
  Failed tests:  5-7
t/03warn-only.t           (Wstat: 0 Tests: 4 Failed: 3)
  Failed tests:  1-3
Files=10, Tests=18,  2 wallclock secs ( 0.07 usr  0.03 sys +  1.16 cusr  0.09 csys =  1.35 CPU)
Result: FAIL
Failed 2/10 test programs. 6/18 subtests failed.
schwern added a commit that referenced this issue Aug 3, 2012
Previously, TBT would not completely reset the test state so the
plan would still be set.  Some tests accidentally relied on this,
anything that would set the plan if it hasn't already been set like
Test::HasVersion or Test::DistManifest.

This change sets a plan in the test test if there was one before
to emulate the behavior.

For #327 and #328
@schwern
Copy link
Contributor Author

schwern commented Aug 3, 2012

That fix solves Test::DistManifest's problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant