Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$hid can be undef #882

Closed
philiprbrenan opened this issue May 13, 2021 · 2 comments
Closed

$hid can be undef #882

philiprbrenan opened this issue May 13, 2021 · 2 comments

Comments

@philiprbrenan
Copy link

In file: 5.30.0/Test2/API.pm

$hid in the highlighted line 395 in the left hand window can easily be undef leading to the results seen in the right hand window.

image
@exodist
Copy link
Member

exodist commented May 13, 2021

Can you give me a reproduction script/test? The intent was that a hub should never be missing an HID, the check for a hub above it should have prevented this. But if there is a (reasonable) cause for a hub to have no ID then the correct thing here might be to assign it one. I need to know the cause of the missing HID though before I can determine the right fix.

@exodist exodist mentioned this issue Apr 27, 2023
Merged
@exodist
Copy link
Member

exodist commented Apr 27, 2023

@philiprbrenan I have submitted a PR. Please let me know if it sufficiently addresses your issue. If it does I can merge it, if not please provide me with more information about what would meet your expectations.

exodist added a commit that referenced this issue Oct 24, 2023
@exodist
Merge pull request #914 from Test-More/fix_882
c9a986f 
Fix #882
exodist added a commit that referenced this issue Oct 24, 2023
@exodist
v1.302196
08474f3 
    - Fix #882
    - Fix handling of VSTRING and LVALUE refs in is_deeply() #918
    - Merge several doc fixes from mauke
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@exodist @philiprbrenan