Text table #109
Text table #109
Conversation
| exampleTable.ElementAt(1).GetExampleValue(0, typeof(int?)).ShouldBe(null); | ||
| exampleTable.ElementAt(1).GetExampleValue(2, typeof(ExecutionOrder)).ShouldBe(ExecutionOrder.Transition); | ||
| var argException = Should.Throw<ArgumentException>(() => exampleTable.ElementAt(1).GetExampleValue(0, typeof(int))); | ||
| argException.Message.ShouldBe("Cannot convert <null> to Int32"); |
There was a problem hiding this comment.
We maybe should put row number, column header name into this exception?
There was a problem hiding this comment.
I don't have the context of this long discussion, but just wondering if it might be possible to have this:
exampleTable.GetExampleValue<int>(0,1)
rather than this:
exampleTable.ElementAt(0).GetExampleValue(1, typeof(int))
There was a problem hiding this comment.
@mwhelan We can't use generics because we get the type from MethodInfo's and other reflection based types, also by the time the Scenario is involved it only has an Example not an ExampleTable (we create a scenario for each Example)
Only the tests will have code like this, the BDDfy codebase will not drill down like this
|
So, things to be done:
The ICollection on ExampleTable is not so much for reading rows, it is more about being able to do this: new ExampleTable("Header1", "Header 2")
{
{ 1, 2 } // We are using collection initialisers here, can they work without implementing ICollection?
} |
| exampleTable.ElementAt(0).GetExampleValue(1, typeof(int)).ShouldBe(2); | ||
| exampleTable.ElementAt(0).GetExampleValue(2, typeof(decimal)).ShouldBe(3m); | ||
| exampleTable.ElementAt(1).GetExampleValue(0, typeof(string)).ShouldBe(null); | ||
| exampleTable.ElementAt(1).GetExampleValue(0, typeof(int?)).ShouldBe(null); |
There was a problem hiding this comment.
Need to verify the date at [1, 1]
There was a problem hiding this comment.
There was a problem hiding this comment.
Haha, comments got in the way. Thanks :)
|
That should be it mate. Thanks :) |
|
Also I can do it if you want. |
|
I dont mind making the suggested changes. If you wanted to pick up one of the other tasks that would be awesome though :) |
|
I love your style @JakeGinnivan. I really do :) I will pick one up tomorrow |
|
K, fixed all the issues raised |
|
Cool. Thanks for the fixes mate. I'll do a final review and merge this soon. |
No description provided.