Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async support #32

Merged
merged 7 commits into from Oct 30, 2013
Merged

Async support #32

merged 7 commits into from Oct 30, 2013

Conversation

@JakeGinnivan
Copy link
Member

@JakeGinnivan JakeGinnivan commented Oct 27, 2013

No description provided.

@MehdiK

This comment has been minimized.

Why is this Explicit? Is it because of delay or the exception? The exception can be verified using LazyBDDfy extension method which returns the engine where you can check for thrown exceptions and also inspect the step that threw it.

This comment has been minimized.

Copy link
Owner

@JakeGinnivan JakeGinnivan replied Oct 29, 2013

The exception, got an example of verifying an exception in that way?

This comment has been minimized.

Copy link

@MehdiK MehdiK replied Oct 29, 2013

Here is an example. You need to somehow find the step you're interested in amongst other steps. I usually use step title.

@MehdiK

This comment has been minimized.

This is in the sample and doesn't matter much; but I wonder why we need this check! The MetaData should always be there.

This comment has been minimized.

Copy link
Owner

@JakeGinnivan JakeGinnivan replied Oct 29, 2013

I was getting a null reference exception for my sample test..

@MehdiK

This comment has been minimized.

When running go.cmd this line throws "Warning as Error: Because this call is not awaited, execution of the current method continues before the call is completed."

@MehdiK
Copy link
Member

@MehdiK MehdiK commented Oct 29, 2013

We need to also wrap the async related code and tests with preprocessor directives so the solution builds for .Net 3.5 too. Can check with #if NET40

@MehdiK
Copy link
Member

@MehdiK MehdiK commented Oct 29, 2013

Cool addition. Thanks Jake. I have commented on a few things. Would appreciate your thoughts.

@JakeGinnivan
Copy link
Member Author

@JakeGinnivan JakeGinnivan commented Oct 29, 2013

@MehdiK all updated. If there is anything else I need to fix, let me know

MehdiK added a commit that referenced this pull request Oct 30, 2013
Async support
@MehdiK MehdiK merged commit c04f840 into TestStack:master Oct 30, 2013
1 check failed
1 check failed
default TeamCity Build TestStack :: BDDfy :: 1. CI finished: Compilation error: Samples\TestStack.BDDfy.Samples\TestStack.BDDfy.Samples.csproj (new)
Details
@MehdiK
Copy link
Member

@MehdiK MehdiK commented Oct 30, 2013

Just noticed CI is broken on the Samples project build! Will check it out later today.

@JakeGinnivan JakeGinnivan deleted the JakeGinnivan:AsyncSupport branch Oct 30, 2013
@JakeGinnivan
Copy link
Member Author

@JakeGinnivan JakeGinnivan commented Oct 30, 2013

NUnit references cannot be found.. that is kinda odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.