New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async support #32

Merged
merged 7 commits into from Oct 30, 2013

Conversation

Projects
None yet
2 participants
@JakeGinnivan
Member

JakeGinnivan commented Oct 27, 2013

No description provided.

@JakeGinnivan JakeGinnivan referenced this pull request Oct 28, 2013

Closed

Support Async methods #31

@MehdiK

This comment has been minimized.

Show comment
Hide comment
@MehdiK

MehdiK Oct 29, 2013

Why is this Explicit? Is it because of delay or the exception? The exception can be verified using LazyBDDfy extension method which returns the engine where you can check for thrown exceptions and also inspect the step that threw it.

Why is this Explicit? Is it because of delay or the exception? The exception can be verified using LazyBDDfy extension method which returns the engine where you can check for thrown exceptions and also inspect the step that threw it.

This comment has been minimized.

Show comment
Hide comment
@JakeGinnivan

JakeGinnivan Oct 29, 2013

Owner

The exception, got an example of verifying an exception in that way?

Owner

JakeGinnivan replied Oct 29, 2013

The exception, got an example of verifying an exception in that way?

This comment has been minimized.

Show comment
Hide comment
@MehdiK

MehdiK Oct 29, 2013

Here is an example. You need to somehow find the step you're interested in amongst other steps. I usually use step title.

MehdiK replied Oct 29, 2013

Here is an example. You need to somehow find the step you're interested in amongst other steps. I usually use step title.

@MehdiK

This comment has been minimized.

Show comment
Hide comment
@MehdiK

MehdiK Oct 29, 2013

This is in the sample and doesn't matter much; but I wonder why we need this check! The MetaData should always be there.

This is in the sample and doesn't matter much; but I wonder why we need this check! The MetaData should always be there.

This comment has been minimized.

Show comment
Hide comment
@JakeGinnivan

JakeGinnivan Oct 29, 2013

Owner

I was getting a null reference exception for my sample test..

Owner

JakeGinnivan replied Oct 29, 2013

I was getting a null reference exception for my sample test..

@MehdiK

This comment has been minimized.

Show comment
Hide comment
@MehdiK

MehdiK Oct 29, 2013

When running go.cmd this line throws "Warning as Error: Because this call is not awaited, execution of the current method continues before the call is completed."

When running go.cmd this line throws "Warning as Error: Because this call is not awaited, execution of the current method continues before the call is completed."

@MehdiK

This comment has been minimized.

Show comment
Hide comment
@MehdiK

MehdiK Oct 29, 2013

Member

We need to also wrap the async related code and tests with preprocessor directives so the solution builds for .Net 3.5 too. Can check with #if NET40

Member

MehdiK commented Oct 29, 2013

We need to also wrap the async related code and tests with preprocessor directives so the solution builds for .Net 3.5 too. Can check with #if NET40

@MehdiK

This comment has been minimized.

Show comment
Hide comment
@MehdiK

MehdiK Oct 29, 2013

Member

Cool addition. Thanks Jake. I have commented on a few things. Would appreciate your thoughts.

Member

MehdiK commented Oct 29, 2013

Cool addition. Thanks Jake. I have commented on a few things. Would appreciate your thoughts.

@JakeGinnivan

This comment has been minimized.

Show comment
Hide comment
@JakeGinnivan

JakeGinnivan Oct 29, 2013

Member

@MehdiK all updated. If there is anything else I need to fix, let me know

Member

JakeGinnivan commented Oct 29, 2013

@MehdiK all updated. If there is anything else I need to fix, let me know

MehdiK added a commit that referenced this pull request Oct 30, 2013

@MehdiK MehdiK merged commit c04f840 into TestStack:master Oct 30, 2013

1 check failed

default TeamCity Build TestStack :: BDDfy :: 1. CI finished: Compilation error: Samples\TestStack.BDDfy.Samples\TestStack.BDDfy.Samples.csproj (new)
Details
@MehdiK

This comment has been minimized.

Show comment
Hide comment
@MehdiK

MehdiK Oct 30, 2013

Member

Just noticed CI is broken on the Samples project build! Will check it out later today.

Member

MehdiK commented Oct 30, 2013

Just noticed CI is broken on the Samples project build! Will check it out later today.

@JakeGinnivan JakeGinnivan deleted the JakeGinnivan:AsyncSupport branch Oct 30, 2013

@JakeGinnivan

This comment has been minimized.

Show comment
Hide comment
@JakeGinnivan

JakeGinnivan Oct 30, 2013

Member

NUnit references cannot be found.. that is kinda odd.

Member

JakeGinnivan commented Oct 30, 2013

NUnit references cannot be found.. that is kinda odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment