Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async support #32

Merged
merged 7 commits into from Oct 30, 2013
Merged

Async support #32

merged 7 commits into from Oct 30, 2013

Conversation

JakeGinnivan
Copy link
Member

No description provided.

@MehdiK
Copy link
Member

MehdiK commented Oct 29, 2013

We need to also wrap the async related code and tests with preprocessor directives so the solution builds for .Net 3.5 too. Can check with #if NET40

@MehdiK
Copy link
Member

MehdiK commented Oct 29, 2013

Cool addition. Thanks Jake. I have commented on a few things. Would appreciate your thoughts.

@JakeGinnivan
Copy link
Member Author

@MehdiK all updated. If there is anything else I need to fix, let me know

MehdiK added a commit that referenced this pull request Oct 30, 2013
@MehdiK MehdiK merged commit c04f840 into TestStack:master Oct 30, 2013
@MehdiK
Copy link
Member

MehdiK commented Oct 30, 2013

Just noticed CI is broken on the Samples project build! Will check it out later today.

@JakeGinnivan JakeGinnivan deleted the AsyncSupport branch October 30, 2013 10:05
@JakeGinnivan
Copy link
Member Author

NUnit references cannot be found.. that is kinda odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants