fix: improve cache invalidation in MockDirectoryInfo #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not going to add the conventional commit prefix as I prefer the repository maintainers to squash-merge my PR and apply the appropriate convention. This is not out of laziness, but rather out of respect: The maintainers will be more familiar with how they wish to deliver my changes. |
fgreinacher
reviewed
Jul 4, 2022
tests/System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryInfoTests.cs
Show resolved
Hide resolved
fgreinacher
suggested changes
Jul 4, 2022
There was a problem hiding this comment.
Thanks a lot @rcdailey! We have a failing test on non-Windows that needs adaptation, otherwise good to go!
When invoking the `Create()` and `Delete()` methods on `MockDirectoryInfo`, the `Exists` property should intrinsically invoke `Refresh()` the next time it is called. This is necessary to prevent returning stale state about the directory after those operations. Additional test cases have been added for `MoveTo()` as well, to ensure it also not returning stale state. For context, this change was motivated by PR TestableIO#828 where similar issues were solved in `MockFileInfo`.
rcdailey
force-pushed
the
directory-info-better-refresh
branch
from
ae2e5b3
to
18d37a8
Compare
|
@fgreinacher Let me know if there's anything else I need to do. Thank you once again for taking the time to review my PR. |
fgreinacher
changed the title
fgreinacher
approved these changes
Jul 19, 2022
fgreinacher
added a commit
that referenced
this pull request
Jul 19, 2022
When invoking the `Create()` and `Delete()` methods on `MockDirectoryInfo`, the `Exists` property should intrinsically invoke `Refresh()` the next time it is called. This is necessary to prevent returning stale state about the directory after those operations. Additional test cases have been added for `MoveTo()` as well, to ensure it also not returning stale state. For context, this change was motivated by PR #828 where similar issues were solved in `MockFileInfo`. Co-authored-by: Florian Greinacher <florian@greinacher.de>
1 task
This was referenced Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking the
Create()andDelete()methods onMockDirectoryInfo, theExistsproperty should intrinsically invokeRefresh()the next time it is called. This is necessary to preventreturning stale state about the directory after those operations.
Additional test cases have been added for
MoveTo()as well, to ensureit also not returning stale state.
For context, this change was motivated by PR #828 where similar issues
were solved in
MockFileInfo.