Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve cache invalidation in MockDirectoryInfo #862

Merged
merged 2 commits into from
Jul 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ public MockDirectoryInfo(IMockFileDataAccessor mockFileDataAccessor, string dire
public override void Delete()
{
mockFileDataAccessor.Directory.Delete(directoryPath);
refreshOnNextRead = true;
}

/// <inheritdoc />
Expand Down Expand Up @@ -160,12 +161,14 @@ public override string Name
public override void Create()
{
mockFileDataAccessor.Directory.CreateDirectory(FullName);
refreshOnNextRead = true;
}

/// <inheritdoc />
public override void Create(DirectorySecurity directorySecurity)
{
mockFileDataAccessor.Directory.CreateDirectory(FullName, directorySecurity);
refreshOnNextRead = true;
}

/// <inheritdoc />
Expand All @@ -178,6 +181,7 @@ public override IDirectoryInfo CreateSubdirectory(string path)
public override void Delete(bool recursive)
{
mockFileDataAccessor.Directory.Delete(directoryPath, recursive);
refreshOnNextRead = true;
}

/// <inheritdoc />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System.Collections.Generic;
using System.Linq;
using System.Security.AccessControl;
using NUnit.Framework;

namespace System.IO.Abstractions.TestingHelpers.Tests
Expand Down Expand Up @@ -444,6 +445,76 @@ public void MockDirectoryInfo_Exists_ShouldUpdateCachedDataOnRefresh()
Assert.IsTrue(directoryInfo.Exists);
}

[Test]
public void Directory_exists_after_creation()
{
// Arrange
var fileSystem = new MockFileSystem();
var directoryInfo = fileSystem.DirectoryInfo.FromDirectoryName(XFS.Path(@"c:\abc"));

// Act
directoryInfo.Create();

// Assert
Assert.IsTrue(directoryInfo.Exists);
}

[Test, WindowsOnly(WindowsSpecifics.AccessControlLists)]
public void Directory_exists_after_creation_with_security()
rcdailey marked this conversation as resolved.
Show resolved Hide resolved
{
// Arrange
var fileSystem = new MockFileSystem();
var directoryInfo = fileSystem.DirectoryInfo.FromDirectoryName(XFS.Path(@"c:\abc"));

// Act
directoryInfo.Create(new DirectorySecurity());

// Assert
Assert.IsTrue(directoryInfo.Exists);
}

[Test]
public void Directory_does_not_exist_after_delete()
{
// Arrange
var fileSystem = new MockFileSystem();
var directoryInfo = fileSystem.Directory.CreateDirectory(XFS.Path(@"c:\abc"));

// Act
directoryInfo.Delete();

// Assert
Assert.IsFalse(directoryInfo.Exists);
}

[Test]
public void Directory_does_not_exist_after_recursive_delete()
{
// Arrange
var fileSystem = new MockFileSystem();
var directoryInfo = fileSystem.Directory.CreateDirectory(XFS.Path(@"c:\abc"));

// Act
directoryInfo.Delete(true);

// Assert
Assert.IsFalse(directoryInfo.Exists);
}

[Test]
public void Directory_still_exists_after_move()
{
// Arrange
var fileSystem = new MockFileSystem();
var directoryInfo = fileSystem.Directory.CreateDirectory(XFS.Path(@"c:\abc"));

// Act
directoryInfo.MoveTo(XFS.Path(@"c:\abc2"));

// Assert
Assert.IsTrue(directoryInfo.Exists);
}

[Test]
public void MockDirectoryInfo_LastAccessTime_ShouldReflectChangedValue()
{
Expand Down Expand Up @@ -584,4 +655,4 @@ public void MockDirectoryInfo_LastWriteTimeUtc_SetterShouldThrowDirectoryNotFoun
}

}
}
}