Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please allow Textual version installed to roll forwards and not be pinned to 0.43 #94

Closed
jamescooke opened this issue Mar 26, 2024 · 3 comments

Comments

@jamescooke
Copy link

Current behaviour

Textual is pinned with a poetry caret requirement in pyproject.toml:

textual = "^0.43.0"

The latest version of which is https://pypi.org/project/textual/0.43.2/ released 29th November 2023.

This is annoying / jarring because:

Expected behaviour

Soften the requirement on Textual so clients / users can get the latest version of Textual when they install Frogmouth - maybe something like:

textual = ">=0.43.0"

Or

textual = "^0"
@davep
Copy link
Contributor

davep commented Mar 26, 2024

This stems from a period when Textual was going through quite a few breaking changes, and needing to remember to reevaluate Frogmouth in the light of those changes wasn't a priority (and was far more extra effort than bumping the pin on occasion). I suspect we're more or less at a point where we can relax this.

davep added a commit that referenced this issue Mar 26, 2024
Also relax things a little now that Textual has calmed down somewhat in
terms of breaking changes. (see #94).
@davep
Copy link
Contributor

davep commented Mar 26, 2024

From the next release it'll now be going out with just a lower-bound for Textual.

@davep davep closed this as completed Mar 26, 2024
davep added a commit that referenced this issue Mar 29, 2024
See #98 and Textualize/textual#4360 for more
context. For the moment this commit will undo the change made in respect to
the request made in #94, but we'll have to remember to unpin again as soon
as the Textual issue is resolved.
@davep
Copy link
Contributor

davep commented Mar 29, 2024

Just to update that I've reverted this change, for the moment, but will go back to this approach again soon. See #99 for context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants