Skip to content

Commit

Permalink
Merge pull request #2613 from xadrianzetx/fix-spinner-style-type
Browse files Browse the repository at this point in the history
Fix type of `spinner_style` argument in `Console.status`
  • Loading branch information
willmcgugan committed Mar 4, 2023
2 parents 3588894 + 81bb9ab commit c5f0890
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Handling of broken `fileno` made more robust. Fixes https://github.com/Textualize/rich/issues/2645
- Fixed missing `fileno` on FileProxy

### Fixed

- Fix type of `spinner_style` argument in `Console.status` https://github.com/Textualize/rich/pull/2613.

### Changed

- Bumped minimum Python version to 3.7 https://github.com/Textualize/rich/pull/2567
Expand Down
2 changes: 2 additions & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ The following people have contributed to the development of Rich:
- [Tomer Shalev](https://github.com/tomers)
- [Serkan UYSAL](https://github.com/uysalserkan)
- [Zhe Huang](https://github.com/onlyacat)
- [Adrian Zuber](https://github.com/xadrianzetx)
- [Ke Sun](https://github.com/ksun212)
- [Qiming Xu](https://github.com/xqm32)
- [James Addison](https://github.com/jayaddison)

2 changes: 1 addition & 1 deletion rich/console.py
Original file line number Diff line number Diff line change
Expand Up @@ -1150,7 +1150,7 @@ def status(
status: RenderableType,
*,
spinner: str = "dots",
spinner_style: str = "status.spinner",
spinner_style: StyleType = "status.spinner",
speed: float = 1.0,
refresh_per_second: float = 12.5,
) -> "Status":
Expand Down

0 comments on commit c5f0890

Please sign in to comment.