Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of spinner_style argument in Console.status #2613

Merged
merged 4 commits into from Mar 4, 2023
Merged

Fix type of spinner_style argument in Console.status #2613

merged 4 commits into from Mar 4, 2023

Conversation

xadrianzetx
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Previously mypy would complain if we passed instance of Style to Console.status since spinner_style was typed as str. Using StyleType fixes this issue.

@willmcgugan willmcgugan merged commit c5f0890 into Textualize:master Mar 4, 2023
@xadrianzetx xadrianzetx deleted the fix-spinner-style-type branch March 5, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xadrianzetx @willmcgugan