Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup escaping fixes #1950

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Markup escaping fixes #1950

merged 3 commits into from
Feb 11, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Feb 10, 2022

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Changes the definition of the Rich markup tags such that they cannot contain a [ inside them, and handles escaping of [ that previously was considered to be a tag, but is now considered part of plain text.

image

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #1950 (fa927d9) into master (e839bfb) will decrease coverage by 0.01%.
The diff coverage is 99.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1950      +/-   ##
==========================================
- Coverage   99.82%   99.81%   -0.02%     
==========================================
  Files          71       71              
  Lines        6943     7034      +91     
==========================================
+ Hits         6931     7021      +90     
- Misses         12       13       +1     
Flag Coverage Δ
unittests 99.81% <99.04%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/default_styles.py 100.00% <ø> (ø)
rich/markdown.py 100.00% <ø> (ø)
rich/syntax.py 99.27% <97.72%> (-0.34%) ⬇️
rich/pretty.py 99.71% <98.88%> (-0.29%) ⬇️
rich/__main__.py 100.00% <100.00%> (ø)
rich/_inspect.py 100.00% <100.00%> (ø)
rich/color.py 100.00% <100.00%> (ø)
rich/console.py 100.00% <100.00%> (ø)
rich/markup.py 100.00% <100.00%> (ø)
rich/measure.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83756d6...fa927d9. Read the comment docs.

Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@willmcgugan willmcgugan merged commit d06540a into master Feb 11, 2022
@willmcgugan willmcgugan deleted the markup-escaping branch February 11, 2022 11:05
This was referenced Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console markup escaping issue [BUG] List of numpy arrays does not print correctly
3 participants