fix: patch mixing width 100% with width auto #4367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dave Pearson <davep@davep.org>
|
EDIT: All tests now pass after poking CI to run again, not sure what was the cause of the previous error. This is failing in CI not due to these changes but because |
|
Closed in favour of #4369. |
TomJGooding
deleted the
fix-patch-mixing-width-100-percent-with-width-auto
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4360 by reverting the change in f094588. This change was intended to fix the issue with
Buttonwidths in #4024, but seems to have had wider unintended consequences. Instead this PR fixes the button width issue by adding aget_content_widthoverride to button, which passes all tests.There may be a wider issue with how relative sizes are handled in Textual, but this patch at least seems to provide a temporary fix.
This will also fix #4354 and other issues mentioned in #4360.
Please review the following checklist.