Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option List update #4667

Merged
merged 14 commits into from
Jun 25, 2024
Merged

Option List update #4667

merged 14 commits into from
Jun 25, 2024

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Jun 20, 2024

Fixes a few issues with the option list / command palette, related to the "style sandwich" problem.

This was prompted by the help text in the command palette, which would not look good when selected, as the alpha was not taken in to account,

  • Re-render prompts with component styles, rather than apply styles after rendering.
  • Calculate option list dimensions earlier.
  • Set command palette help text to dim.
  • Style tweak to command palette.

@willmcgugan willmcgugan marked this pull request as draft June 20, 2024 14:25
@willmcgugan willmcgugan changed the title start new option list Option List update Jun 22, 2024
@willmcgugan willmcgugan marked this pull request as ready for review June 25, 2024 16:18
@willmcgugan willmcgugan merged commit 97f9e44 into main Jun 25, 2024
20 checks passed
@willmcgugan willmcgugan deleted the new-option-list branch June 25, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant