Commits on Nov 24, 2021

1. Always use the correct representation when drawing image …

   Before this change, the image asset (which may contain multiple reps
   of an image for differing traits) was only consulted when the trait
   collection changed. But in cases where display was scheduled
   on the node and the trait collection had not changed, the image node
   ends up with the default representation instead.
   
   An example of this:
   
   You have an image asset with two versions: light (default) and dark.
   The device is currently in dark mode
   The image is being presented in an item in a collection node.
   
   1. Item node is first added to hierarchy. Trait collection doesn't match
   so regenerateFromImageAsset=true.
   2. Dark image is rendered, as expected
   3. Item node is scrolled off screen
   4. Item is scrolled back on screen
   5. This triggers display on the item node
   6. Trait collection has NOT changed so regenerateFromImageAsset=false
   7. So, imageAsset is not consulted and default (Light) image is rendered
   
   After looking at this a lot, I don’t see any reason why we need the
   regenerateFromImageAsset flag at all (introduced in TextureGroup#1663).  Whenever
   the image node is displayed we need to make sure we are generating the
   correct representation.

   

   bdolman committed Nov 24, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for fa9bbe8
   • Browse repository at this point

   Copy the full SHA

   fa9bbe8 View commit details

   Browse the repository at this point in the history