Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use STL implementation over in-house version #73

Closed
prince-chrismc opened this issue Jun 26, 2020 · 1 comment · Fixed by #81
Closed

Use STL implementation over in-house version #73

prince-chrismc opened this issue Jun 26, 2020 · 1 comment · Fixed by #81

Comments

@prince-chrismc
Copy link
Collaborator

Follow up from #71

There are several c++17 and fundamentals v2 which have been copied to provide compatible c++11 support.

Type feature macro header
make_void __cpp_lib_void_t (maybe) <type_traits>
void_t __cpp_lib_void_t <type_traits>
nonesuch __cpp_lib_experimental_detect <experimental/type_traits>
is_detected __cpp_lib_experimental_detect <experimental/type_traits>

Despite this being common practice, we should be checking the feature macro and when available use the STL implementation otherwise fallback to the in house one for compatibility.

The travis matrix should be expanded to test on multiple cppstd versions.

\cc @Thalhammer

Thalhammer added a commit that referenced this issue Jun 27, 2020
@Thalhammer
Copy link
Owner

I have implemented using void_t if available, however as none of my compilers support std::is_detected (yet) I'll post pone this.

prince-chrismc added a commit to prince-chrismc/jwt-cpp that referenced this issue Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants