Added support for openssl 1.1. Removed gtest src dependencies #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
galuha
commented
Jul 14, 2018
galuha
commented
- Added support for openssl 1.1.
- Removed gtest src dependencies, that caused unnecessary make editing
- Removed std=c++14 dependencie in order to support older compilers
Thalhammer
reviewed
Jul 14, 2018
include/jwt-cpp/jwt.h
Outdated
| } | ||
| }; | ||
| struct default_clock { | ||
| std::chrono::_V2::system_clock::time_point now() const { |
There was a problem hiding this comment.
Shouldn't this be std::chrono::system_clock::time_point ?
Otherwise thank you for your contribution, will merge as soon as possible.
There was a problem hiding this comment.
Fixed. And thank you for this lightweight library
|
Did some improvements in e162b97 to support older compilers and keep the tests clean, but otherwise good work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.