Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Python cache #19

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Better Python cache #19

wants to merge 8 commits into from

Conversation

ThatXliner
Copy link
Owner

@ThatXliner ThatXliner commented May 25, 2024

Pull Request Check List

Applicable issues

Description of PR

See respective issue

Alternative designs considered

Keep the existing behavior of using the latest Python. I don't think this should break things if the Python version specified in the script is correct.

@ThatXliner
Copy link
Owner Author

TODO: add tests

@ThatXliner ThatXliner marked this pull request as draft May 25, 2024 21:51
Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.57%. Comparing base (64ac722) to head (0a42525).
Report is 2 commits behind head on main.

Current head 0a42525 differs from pull request most recent head 1a2095e

Please upload reports for the commit 1a2095e to get more accurate results.

Files Patch % Lines
idae/resolver.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   94.61%   93.57%   -1.05%     
==========================================
  Files           7        7              
  Lines         130      140      +10     
==========================================
+ Hits          123      131       +8     
- Misses          7        9       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant