Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST]: Improve requires-python resolution #14

Open
3 tasks done
richieadler opened this issue May 14, 2024 · 2 comments
Open
3 tasks done

[REQUEST]: Improve requires-python resolution #14

richieadler opened this issue May 14, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@richieadler
Copy link

richieadler commented May 14, 2024

Prerequisites

  • I have searched the issues and believe that it has not already been requested (and possibly rejected)
  • I have made sure that this feature isn't possible with this project's plugin system and/or configuration; core changes must be made to make this happen.
  • I agree to follow the Code of Conduct

Feature description

Improve the logic to re-use existing venvs for valid requires-python clauses.

Rationale

Currently requires-python tries to find the higher Python available and creates a venv accordingly, even if the clause would be satisfied by an existing venv.

Scenario:

  • Windows 11
  • Python 3.11.9 and 3.12.3 installed
  • requires-python = ">=3.11,<3.12"

Script runs with 3.11.9 correctly.

  • Changed to requires-python = ">=3.11"

It creates a new 3.12.3 venv instead of using the pre-existing 3.11.9 for which the requires-python clause is still valid.

@richieadler richieadler added the enhancement New feature or request label May 14, 2024
@ThatXliner ThatXliner pinned this issue May 18, 2024
ThatXliner added a commit that referenced this issue May 25, 2024
@richieadler
Copy link
Author

richieadler commented May 25, 2024 via email

@ThatXliner
Copy link
Owner

Yea, it’s still in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants