Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix write disposition #170

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix write disposition #170

merged 1 commit into from
Jun 26, 2023

Conversation

jdddog
Copy link
Contributor

@jdddog jdddog commented Jun 26, 2023

OpenCitations shouldn't be using append and the main table of Crossref Events can use the default write empy.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (b7ed3d3) 95.79% compared to head (20a6529) 95.75%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
- Coverage    95.79%   95.75%   -0.05%     
===========================================
  Files           19       19              
  Lines         4642     4642              
  Branches       622      622              
===========================================
- Hits          4447     4445       -2     
- Misses         122      123       +1     
- Partials        73       74       +1     
Impacted Files Coverage Δ
...y_workflows/workflows/crossref_events_telescope.py 87.82% <ø> (ø)
...ry_workflows/workflows/open_citations_telescope.py 95.90% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@keegansmith21 keegansmith21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks Jamie!

@keegansmith21 keegansmith21 merged commit 5019bbc into develop Jun 26, 2023
2 of 3 checks passed
@jdddog jdddog deleted the fix/write-disposition branch October 20, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants