Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DOI table #171

Merged
merged 8 commits into from
Aug 2, 2023
Merged

Refactor DOI table #171

merged 8 commits into from
Aug 2, 2023

Conversation

jdddog
Copy link
Contributor

@jdddog jdddog commented Jul 3, 2023

Refactors the DOI table:

  • Moved the real Unpaywall data into its own struct.
  • Moved COKI generated data into the coki struct.
  • Add Black OA to coki.oa.colors based on whether DOI is in SciHub.
  • Removed MAG from DOI table.
  • Removed Elastic export tables.
  • Updated test data for oa web workflow.
  • Made Unpaywall test data not cover all outputs from Crossref Metadata, which is how the datasets work in reality.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 94.82% and project coverage change: -0.17% ⚠️

Comparison is base (afd3453) 95.80% compared to head (85e7d17) 95.64%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #171      +/-   ##
===========================================
- Coverage    95.80%   95.64%   -0.17%     
===========================================
  Files           19       19              
  Lines         4649     4589      -60     
  Branches       624      614      -10     
===========================================
- Hits          4454     4389      -65     
- Misses         122      127       +5     
  Partials        73       73              
Files Changed Coverage Δ
...observatory_workflows/workflows/oa_web_workflow.py 96.06% <ø> (ø)
...ic_observatory_workflows/workflows/doi_workflow.py 95.47% <50.00%> (-1.42%) ⬇️
academic_observatory_workflows/model.py 97.25% <96.42%> (-0.53%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdddog jdddog marked this pull request as ready for review July 25, 2023 01:27
@jdddog jdddog force-pushed the feature/doi-table-refactor branch from fa303aa to d1a4751 Compare July 26, 2023 04:19
Copy link
Contributor

@keegansmith21 keegansmith21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Jamie! I just had a question about a line, but feel free to merge when ready

@jdddog jdddog force-pushed the feature/doi-table-refactor branch from d1a4751 to 85e7d17 Compare August 2, 2023 02:49
@jdddog jdddog merged commit deab587 into develop Aug 2, 2023
1 of 3 checks passed
@jdddog jdddog deleted the feature/doi-table-refactor branch August 2, 2023 03:23
@jdddog jdddog mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants