Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hmac key #632

Merged
merged 3 commits into from
Aug 21, 2023
Merged

hmac key #632

merged 3 commits into from
Aug 21, 2023

Conversation

keegansmith21
Copy link
Contributor

@keegansmith21 keegansmith21 commented Aug 16, 2023

I have recently required the use of an HMAC key. I thought that I should create one and add it as an airflow connection, but discovered that you can just make one on the fly using your service account credentials. So I made this - which also deletes the key when the context manager closes.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (724bfd7) 86.64% compared to head (611cbb5) 86.64%.
Report is 1 commits behind head on develop.

❗ Current head 611cbb5 differs from pull request most recent head dd81415. Consider uploading reports for the commit dd81415 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #632   +/-   ##
========================================
  Coverage    86.64%   86.64%           
========================================
  Files           34       34           
  Lines         4626     4636   +10     
  Branches       559      559           
========================================
+ Hits          4008     4017    +9     
- Misses         500      505    +5     
+ Partials       118      114    -4     
Files Changed Coverage Δ
observatory-platform/observatory/platform/gcs.py 69.53% <100.00%> (+0.33%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keegansmith21 keegansmith21 marked this pull request as ready for review August 17, 2023 05:41
Copy link
Contributor

@jdddog jdddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Keegan, it looks good.

@keegansmith21 keegansmith21 merged commit 079aafe into develop Aug 21, 2023
4 checks passed
@keegansmith21 keegansmith21 deleted the feature/HMAC_key_generator branch August 21, 2023 04:46
jdddog pushed a commit that referenced this pull request Feb 25, 2024
* hmac key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants