Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added glob match functionality to list_blobs #633

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

keegansmith21
Copy link
Contributor

@keegansmith21 keegansmith21 commented Aug 17, 2023

Added the ability to match on a glob pattern to the gcs_list_blobs function

@keegansmith21 keegansmith21 marked this pull request as ready for review August 17, 2023 07:26
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09% 🎉

Comparison is base (d2a432f) 86.59% compared to head (f8dabb3) 86.69%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #633      +/-   ##
===========================================
+ Coverage    86.59%   86.69%   +0.09%     
===========================================
  Files           34       34              
  Lines         4626     4636      +10     
  Branches       559      559              
===========================================
+ Hits          4006     4019      +13     
+ Misses         505      500       -5     
- Partials       115      117       +2     
Files Changed Coverage Δ
observatory-platform/observatory/platform/gcs.py 70.15% <100.00%> (+1.58%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jdddog jdddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Keegan, looks good.

@jdddog jdddog force-pushed the feature/list_blobs_match_glob branch from f66fb04 to f8dabb3 Compare August 21, 2023 04:58
@keegansmith21 keegansmith21 merged commit b4b1c30 into develop Aug 21, 2023
4 checks passed
@keegansmith21 keegansmith21 deleted the feature/list_blobs_match_glob branch August 21, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants