Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tasks integration #5

Closed
The-Compiler opened this issue Jun 18, 2021 · 2 comments
Closed

Tasks integration #5

The-Compiler opened this issue Jun 18, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@The-Compiler
Copy link
Owner

We should probably be a Task Provider rather than directly opening a terminal ourselves?
@The-Compiler The-Compiler added the enhancement New feature or request label Jun 18, 2021
@dariuszparys
Copy link
Contributor

@The-Compiler I was thinking about the task provider integration. Currently the extension is using a command to execute the environments or multiple. In case of a task integration, you would lose multiselect. You usually do this with dependencies in the tasks themselves. Do you think this would be valuable to have in addition to the existing command or was your thinking exchanging the current implementation?

@dariuszparys dariuszparys mentioned this issue Apr 13, 2022
Merged
@The-Compiler
Copy link
Owner Author

@dariuszparys Thanks for your implementation! I originally thought we could replace the current implementation entirely, but I wasn't aware of those limitations. I suppose things look similar for passing arguments to tox (added in #9) - even though it sounds like that might be possible using Input Variables somehow.

Thus, I think it would be best to keep the existing commands-based implementation alongside the tasks integration. Closing this as #12 has been merged now. However, I'll open a couple of follow-up issues, where I'd appreciate getting some help if possible!

@The-Compiler The-Compiler mentioned this issue Jul 6, 2022
Closed
The-Compiler added a commit that referenced this issue Jul 6, 2022
@The-Compiler
tests: Set up initial examples workspace when launching
46ecf1f 
- microsoft/vscode#69335
- microsoft/vscode#78740
- https://stackoverflow.com/questions/55456193/testing-a-vscode-extension-that-involves-opening-a-folder-workspace

Fixes #26, follow-up for #5/#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dariuszparys @The-Compiler