Skip to content
This repository has been archived by the owner on Jun 13, 2022. It is now read-only.

#3 - IMPROVEMENT: Convert resource script to jQuery #42

Closed
wants to merge 7 commits into from
Closed

Conversation

karx1
Copy link
Member

@karx1 karx1 commented Oct 14, 2020

Your PR should be for a corresponding issue. If the issue doesn't exist yet, create that issue and mention the issue in your PR.

Add one of the following prefixes for your PR:

  • [ [ISSUE-LABEL] - FEATURE ]
  • [ [ISSUE-LABEL] - FIX ]
  • [ [ISSUE-LABEL] - IMPROVEMENT ]

Your PR should contain a description of the changes you made.
The description should be within 250 words. Please try to follow this word limit.

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

Am I familiar with the tech stack of this project? (Important for PRs that have code changes)

  • Yes
  • No.

If yes, please mention the back-end framework used in this project. - Django

Have I contributed before to DomeCode? (req.)

  • Yes, once.
  • Yes, more than once but not a lot.
  • Yes, extensively.
  • No.

Have I used DomeCode? (req.)

  • Not a lot.
  • Extensively.
  • Nope.

This PR converts the resource script (resources.js) to use jQuery instead of normal JavaScript.
The script is now only 40 lines long, compared to 60, and only takes 10 ms to complete, compared to 23-34.

This PR addresses #3.

@karx1 karx1 requested a review from arthtyagi as a code owner October 14, 2020 01:15
@arthtyagi
Copy link
Member

1. No issue created

  1. We don't need any more of JQuery.

@arthtyagi arthtyagi closed this Oct 14, 2020
@karx1 karx1 mentioned this pull request Oct 14, 2020
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants