Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Reorganize the components and theme creation API #45

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

🎨 Reorganize the components and theme creation API #45

wants to merge 51 commits into from

Conversation

BattleCh1cken
Copy link
Contributor

@BattleCh1cken BattleCh1cken commented May 21, 2024 •
edited
Loading

Summary

Closes #44 and #28.

Checklist

  • I have fully tested all of the added features
  • I have fully documented all of the relevant code
    • Document all of the components
    • Update the theme implementation docs
  • rules constructor
  • various component constructors
    • decision-matrix
    • admonitions
    • plot
    • pie-chart
  • finish porting radial and linear to the new constructors
  • unify theme's handling of the type parameter

Additional Notes

@BattleCh1cken BattleCh1cken mentioned this pull request May 21, 2024
Draft
4 tasks
@BattleCh1cken
✨ Implement make-glossary
09baab2
@BattleCh1cken
✨ Implement make-pro-con
df42356
@BattleCh1cken
💘 Break ci
2bbe4c1
@BattleCh1cken
💚 Fix ci
1cc6687
@BattleCh1cken
💚 Fix ci
18a3d55
@BattleCh1cken
💘 Break ci
5790226
@BattleCh1cken
💚 Fix ci
e59a3ad
@BattleCh1cken
👷 Ci will now cancel old workflows
b72bd87
@BattleCh1cken
👷 Docs ci will now cancel past runs
a91abd5
@BattleCh1cken
🚧 Started work on theme constructors and error handling
5e3f27c
@BattleCh1cken
✨ Wrote a constructor for cover
e989869
@BattleCh1cken
💚 Workflows should no longer cancel each other
a8f9332
@BattleCh1cken
✨ Make constructors for rules and admonitions
d3906f7
@BattleCh1cken
🎨 Finish porting linear and radial to the new constructors
c7b7293
@BattleCh1cken
⬆️ Update typstfmt
f278a86
@BattleCh1cken
📝 Recompile glossary
bd92a74
@BattleCh1cken
🎨 Finally the formatting in this file makes sense
49878ec
@BattleCh1cken
🎨 Even more formatting
a71a2fa
@BattleCh1cken
🎨 Just went ahead and formatted everything
4e60305
@BattleCh1cken
✨ Implement decision matrix constructor
3372b27
@BattleCh1cken
✨ Rewrite the linear decision matrix
2e5b95d
@BattleCh1cken
✨ Port the radial decision matrix to the new constructor
7b4d3a2
@BattleCh1cken BattleCh1cken mentioned this pull request May 23, 2024
Closed
@BattleCh1cken BattleCh1cken marked this pull request as ready for review May 23, 2024 18:24
BestUsernamEver
BestUsernamEver requested changes May 27, 2024
View reviewed changes
docs/src/developer_documentation/custom_themes.md Outdated Show resolved Hide resolved
docs/src/developer_documentation/custom_themes.md Show resolved Hide resolved
docs/src/reference.typ Show resolved Hide resolved
themes/default/components.typ Outdated Show resolved Hide resolved
themes/default/components.typ Outdated Show resolved Hide resolved
@BestUsernamEver BestUsernamEver self-requested a review June 1, 2024 00:53
RubyflameWarrior
RubyflameWarrior reviewed Jun 2, 2024
View reviewed changes
justfile Show resolved Hide resolved
lib.typ Show resolved Hide resolved
lib.typ Show resolved Hide resolved
utils/components.typ Show resolved Hide resolved
utils/components.typ Show resolved Hide resolved
docs/src/developer_documentation/custom_themes.md Outdated Show resolved Hide resolved
docs/src/developer_documentation/custom_themes.md Outdated Show resolved Hide resolved
docs/src/developer_documentation/custom_themes.md Show resolved Hide resolved
docs/src/developer_documentation/custom_themes.md Outdated Show resolved Hide resolved
docs/src/developer_documentation/custom_themes.md Outdated Show resolved Hide resolved
BattleCh1cken and others added 4 commits June 5, 2024 13:49
@BattleCh1cken @RubyflameWarrior
📝 Update docs/src/developer_documentation/custom_themes.md
c69aac2 
Co-authored-by: RubyflameWarrior <104446839+RubyflameWarrior@users.noreply.github.com>
@BattleCh1cken @RubyflameWarrior
📝 Update docs/src/developer_documentation/custom_themes.md
4f75401 
Co-authored-by: RubyflameWarrior <104446839+RubyflameWarrior@users.noreply.github.com>
@BattleCh1cken @RubyflameWarrior
📝 Update docs/src/developer_documentation/custom_themes.md
c9e3636 
Co-authored-by: RubyflameWarrior <104446839+RubyflameWarrior@users.noreply.github.com>
@BattleCh1cken
📝 Replace a TODO comment with something clearer
49efe3b
BattleCh1cken and others added 10 commits June 6, 2024 20:16
@BattleCh1cken @RubyflameWarrior
📝 Update utils/components.typ
176daaa 
Co-authored-by: RubyflameWarrior <104446839+RubyflameWarrior@users.noreply.github.com>
@BattleCh1cken
📝 Wrote the documentation for the theme constructors
716c770
@BattleCh1cken @RubyflameWarrior
📝 Update utils/theme.typ
8b8f50e 
Co-authored-by: RubyflameWarrior <104446839+RubyflameWarrior@users.noreply.github.com>
@BattleCh1cken @RubyflameWarrior
📝 Update utils/theme.typ
a35db8a 
Co-authored-by: RubyflameWarrior <104446839+RubyflameWarrior@users.noreply.github.com>
@BattleCh1cken @RubyflameWarrior
📝 Update themes/radial/components/gantt-chart.typ
38af672 
Co-authored-by: RubyflameWarrior <104446839+RubyflameWarrior@users.noreply.github.com>
@BattleCh1cken @RubyflameWarrior
📝 Update docs/src/developer_documentation/custom_themes.md
12fdc12 
Co-authored-by: RubyflameWarrior <104446839+RubyflameWarrior@users.noreply.github.com>
@BattleCh1cken @RubyflameWarrior
📝 Update themes/themes.typ
4b45df7 
Co-authored-by: RubyflameWarrior <104446839+RubyflameWarrior@users.noreply.github.com>
@BattleCh1cken
📝 Added credit for the linear theme
5e8647f
@BattleCh1cken
✨ Added admonition categories for the the edp steps
364648a
@BattleCh1cken
🐛 Fixed inconsistent spacing in the default TOC
dde1416
@BattleCh1cken BattleCh1cken mentioned this pull request Jun 11, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deb06 deb06 Awaiting requested review from deb06

@RubyflameWarrior RubyflameWarrior Awaiting requested review from RubyflameWarrior

@BestUsernamEver BestUsernamEver Awaiting requested review from BestUsernamEver

Assignees

@BattleCh1cken BattleCh1cken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Standardize the components and theme creation API
3 participants
@BattleCh1cken @RubyflameWarrior @BestUsernamEver