-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform SG13G2 misses antenna diode definition in the LEF #1981
Comments
The lack of a cell should be filed against https://github.com/IHP-GmbH/IHP-Open-PDK. If such a cell exists then this request could be fufilled. |
Created an issue: IHP-GmbH/IHP-Open-PDK#92 I propose to keep both issues open, one to get the antenna diode in the LEF, and then check that ORFS is actually using it. |
That cell exists in our copy but lacks ANTENNACELL. I'll see if we can pull in the update. |
@hpretl @maliberty @rovinski since there was an update on different views used for digital design there is also the |
@maliberty I wouldn't really know what to do except run the flow and see what happens, but @KrzysztofHerman already tried that (see above). The question is why there are still antenna fails left. |
What does "throws antenna issues" mean? Is it that the tool fails or just that not all issues were fixed? We do have some improvements in antenna fixing in progress. |
There are still antenna violations in the |
@eder-matheus I ran ihp-sg13g2/riscv32i and I see
but the subsequent check shows violations. |
@maliberty I've found the issue. The API used by repair_antennas to get the violations from antenna_checker is broken. It only computes the PAR values, not the CAR. If you look at the logs, there are only CAR violations. I'll try to fix it. Hopefully, it will be a small update. But this is something to remember in the new antenna checker (@luis201420 ). |
@eder-matheus is this resolved now that the new checker is in? |
Description
In the ORFS the
repair_antennas
command is used for antenna repair. This requires anANTENNACELL
to be declared in the LEF, see https://openroad.readthedocs.io/en/latest/main/src/grt/README.html#repair-antennas.In the moment, this seems missing.
Suggested Solution
Add
ANTENNACELL
tosg13g2_stdcell.lef
(at least I think this would be the right place, but I am not sure about this). @KrzysztofHerman please take a look into this.It would also be good if antenna diodes could be placed at every input, but since only p-type antenna diodes are available in the standard cells that could lead to trouble, if a block is powered down and ties the inputs to VSS via the antenna diodes.
Additional Context
No response
The text was updated successfully, but these errors were encountered: