ant: return CAR and CSR violations to repair_antennas #5242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Jun 13, 2024
src/ant/src/AntennaChecker.cc
Outdated
Comment on lines
754
to
761
| if (layer->getRoutingLevel() != 0) { | ||
| auto psr_violation | ||
| = checkPSR(layer, node_info, verbose, report, report_file); | ||
| bool csr_violation | ||
| = checkCSR(layer, node_info, verbose, report, report_file); | ||
| node_has_violation | ||
| = node_has_violation || psr_violation.first || csr_violation; | ||
| } |
There was a problem hiding this comment.
Does check* have a side-effect or should we skip this if node_has_violation was already set by PAR/CAR?
There was a problem hiding this comment.
We should not skip because a net can have both PAR/CAR and PSR/CSR. Skipping it will give us the wrong number of violations and make the report incorrect.
src/ant/src/AntennaChecker.cc
Outdated
Comment on lines
749
to
752
| bool node_has_violation = false; | ||
| auto par_violation = checkPAR(layer, node_info, verbose, report, report_file); | ||
| bool car_violation = checkCAR(layer, node_info, verbose, report, report_file); | ||
| node_has_violation = par_violation.first || car_violation; |
There was a problem hiding this comment.
There's no need to define node_has_violation and then set it afterwards, just combine 749 & 752
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes The-OpenROAD-Project/OpenROAD-flow-scripts#1981
This is an initial implementation, as mentioned in a comment in the code. Using this naive approach, we can reduce the number of nets with violations from 81 to 55 in ihp-sg13g2/riscv32i.