makefile: improve logging, include name of stage as well as which script is running #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipt is running Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
|
How about either of |
the stage filename stems and which outputs are produced is somewhat idiosyncratic and in some places inconsistent and ambigious(such as finish/final). Therefore simply log "Running pdn.tcl, stage 2_floorplan_pdn". This is accurate and precise as far as we can be and remains accurate if filename stems and inputs/outputs are made more consistent in the future. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Fixed. |
maliberty
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reminder is useful to find files, or e.g. rerun a stage
make do-2_6_floorplan_pdnAfter:
Before