Rsz update longe wire buffer insertion #4801
Conversation
Signed-off-by: arthur <arthurjolo@gmail.com>
Signed-off-by: arthur <arthurjolo@gmail.com>
Signed-off-by: arthur <arthurjolo@gmail.com>
Signed-off-by: arthur <arthurjolo@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: arthur <arthurjolo@gmail.com>
Signed-off-by: arthur <arthurjolo@gmail.com>
Signed-off-by: arthur <arthurjolo@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: arthur <arthurjolo@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: arthur <arthurjolo@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: arthur <arthurjolo@gmail.com>
Signed-off-by: arthur <arthurjolo@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: arthur <arthurjolo@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
| @@ -851,7 +851,8 @@ void RepairDesign::repairNetWire( | |||
| level, | |||
| units_->distanceUnit()->asString(dbuToMeters(wire_length), 1), | |||
| units_->distanceUnit()->asString(dbuToMeters(max_length_), 1)); | |||
| split_length = min(split_length, max(max_length_ - wire_length_ref, 0)); | |||
| split_length = min(max_length_, length / 2); | |||
There was a problem hiding this comment.
This reintroduces what was fixed in 3b97c56
There was a problem hiding this comment.
I believe this was overwritten during a merge. But I think it is easy to fix: split_length = min(length / 2, max(max_length_ - wire_length_ref, 0));
This should account for both changes, @povik do you agree?
There was a problem hiding this comment.
Yes, that looks good to me! (I was lazy to type that out myself...)
There was a problem hiding this comment.
@arthurjolo please make a PR for your fix.
Fixes #4006
This PR changes the position of buffers inserted to fix long wires.
The new position is set to be the the middle of the wire, previously it was set to be on the max wire length allowed causing some buffers to be inserted near the drivers.