Inspector: add width, height for convenience alongside BBox #5025
Conversation
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
src/gui/src/gui.cpp
Outdated
| props.push_back({"Width", std::string(Descriptor::Property::convert_dbu(bbox.dx(), false))}); | ||
| props.push_back({"Height", std::string(Descriptor::Property::convert_dbu(bbox.dy(), false))}); |
There was a problem hiding this comment.
You might want to consider making these "BBox height and width" since are already used in several of the descriptors and overlapping names makes it impossible to access these from the tcl.
There was a problem hiding this comment.
Are the properties not scoped by the type they refer to?
There was a problem hiding this comment.
I am out of my depth here... I just hacked things until I saw something convenient in the GUI....
It is probably easier for someone skilled.in the art to make the two line change than to train me to do it.
Should I close this PR?
There was a problem hiding this comment.
I think he is just referring to the string "Width" versus "BBox Width" or the like. We can probably work it out in this PR.
There was a problem hiding this comment.
could I append width/height to BBox or separate line?
I am confused about how Tcl enters into this.
There was a problem hiding this comment.
There are GUI commands in tcl that can access the properties. @gadfort implemented it so he is best to answer.
There was a problem hiding this comment.
There is no scoping, i was just suggesting renaming the text from "Width" to "BBox width" (same for height) to avoid property name collisions. Shouldnt require much effort.
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
|
|
Missing ) |
|
Fixed. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Missing DCO |
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Fixed, force pushed. |
|
clang-tidy review says "All clean, LGTM! 👍" |
Example use case: compare dimensions of two macros.