Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple readers #4

Closed
34 tasks done
The4thLaw opened this issue Aug 7, 2017 · 1 comment
Closed
34 tasks done

Add support for multiple readers #4

The4thLaw opened this issue Aug 7, 2017 · 1 comment

Comments

@The4thLaw
Copy link
Owner

The4thLaw commented Aug 7, 2017

Work in a branch!

  • Have a page to select the current reader (don’t rely on Spring Security, there’s no need to secure this). The available users could be presented in a fancy way, centered on the screen
    • Redirect to it if the user is not selected
    • Allow editing readers and adding new ones from there
    • Allow removing readers as well
    • Have a “Demyo” user by default
    • It should be possible to switch users from the menu, like in other MDL apps
      • Selection page
      • Entry in menu page
    • Mockup for the page: https://jsfiddle.net/5suonp4o/3/
  • Each reader must have its reading list
  • A reader can manually add items to his reading list
    • Individual Albums (if not in the wishlist)
    • Whole Series (except those in the wishlist. Don’t add the option for empty Series or Series with only wishlist items)
  • Adding an Album must add it to the reading list of all readers, except if it’s in the wishlist
    • Adding an Album to the wishlist after its initial creation should remove it from the reading list
    • Removing an Album from the wishlist should add it to the reading list of all readers
  • Each reader may have its favorites
  • When an Album is in the reading list, there should be an indicator in the Series view and it should be possible to mark it from there (from the context menu). A round trip to the server is acceptable
  • When an Album is in the reading list, there should be a FAB on the view page
  • Change links from /readers/favourites/1 to /readers/1/favourites for a more "RESTy" feel
  • Make a page for the reading list per user (started, not yet tested)
  • Handle export
  • Handle import
  • ~~~Add a whole series to the reading list~~~ --> not really useful
@The4thLaw The4thLaw added this to the v2.1.0 milestone Aug 7, 2017
@The4thLaw The4thLaw added impact:backend impact:ui impact:database Requires changes in the database labels Aug 7, 2017
The4thLaw added a commit that referenced this issue Oct 29, 2017
The4thLaw added a commit that referenced this issue Oct 29, 2017
The4thLaw added a commit that referenced this issue Oct 29, 2017
The4thLaw added a commit that referenced this issue Nov 3, 2017
The4thLaw added a commit that referenced this issue Nov 25, 2017
The4thLaw added a commit that referenced this issue Nov 25, 2017
Still missing backend for removal and animations.
Refs #4.
The4thLaw added a commit that referenced this issue Jun 19, 2018
The4thLaw added a commit that referenced this issue Jun 25, 2018
The4thLaw added a commit that referenced this issue Jun 30, 2018
The4thLaw added a commit that referenced this issue Jun 30, 2018
The4thLaw added a commit that referenced this issue Jun 30, 2018
The4thLaw added a commit that referenced this issue Jun 30, 2018
Also started the view of the reading list, but not yet tested as there is no code to add favourites.

Refs #4
The4thLaw added a commit that referenced this issue Jul 2, 2018
The4thLaw added a commit that referenced this issue Jul 2, 2018
Also includes minor tweaks to the JS styling, and a toast helper.

Refs #4
The4thLaw added a commit that referenced this issue Aug 25, 2018
Refs #4

Also integrates a basic unit test, to be completed as part of #3 .
The4thLaw added a commit that referenced this issue Aug 25, 2018
Refs #4

Also starts a test for the import (see #2 )
@The4thLaw The4thLaw self-assigned this Aug 25, 2018
The4thLaw added a commit that referenced this issue Aug 26, 2018
The4thLaw added a commit that referenced this issue Aug 26, 2018
@The4thLaw
Copy link
Owner Author

A few notes:

  • It's not possible to add an album to the reading list from the series views because
    • The album is added automatically to the reading list when added to the library
    • The series can be added as a whole
    • It would only cost an additional click to do it from the album view (click album, open menu, click item)
  • It's not possible to remove an album from the reading list from the series views because it would cost two clicks (menu, item) and the alternative has the same cost (open album, click FAB)

The4thLaw added a commit that referenced this issue Aug 26, 2018
The4thLaw added a commit that referenced this issue Aug 31, 2018
Still 1 IT failing

Refs #4
The4thLaw added a commit that referenced this issue Oct 21, 2018
The4thLaw added a commit that referenced this issue Nov 5, 2018
The4thLaw added a commit that referenced this issue Nov 14, 2018
Load only the IDs instead of loading the entities: we don't need anything else.
Refs #4
The4thLaw added a commit that referenced this issue Nov 14, 2018
Currently used for the reading list and favourites.
Refs #4
The4thLaw added a commit that referenced this issue Jan 3, 2019
The current setup prevented the Reader from seeing changes for example, once adding an Album, he would not see it in his reading list immediately, which is very confusing.

Refs #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant